Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/koofr): set test for koofr #4050

Merged
merged 8 commits into from
Jan 24, 2024
Merged

feat(services/koofr): set test for koofr #4050

merged 8 commits into from
Jan 24, 2024

Conversation

suyanhanx
Copy link
Member

No description provided.

Xuanwo
Xuanwo reviewed Jan 22, 2024
View reviewed changes
core/src/services/koofr/backend.rs Outdated Show resolved Hide resolved
core/tests/behavior/async_copy.rs Outdated Show resolved Hide resolved
@suyanhanx
Copy link
Member Author

@hoslo
I found that the copy function may have problems when executing the copy tests in multiple threads.
The other tests are fine. Only the copy tests only pass when test_threads is 1.

Could you help me to take a look?

@hoslo hoslo mentioned this pull request Jan 24, 2024
Merged
@hoslo
Copy link
Contributor

hoslo commented Jan 24, 2024

test_threads

@hoslo I found that the copy function may have problems when executing the copy tests in multiple threads. The other tests are fine. Only the copy tests only pass when test_threads is 1.

Could you help me to take a look?

When test_threads is not 1, it is possible to create an existing dir, in which case koofr will return 400, which we should consider a success.

@Xuanwo Xuanwo closed this in #4062 Jan 24, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Jan 24, 2024

Oh, fixes #xxx will close a pr directly...

@Xuanwo Xuanwo reopened this Jan 24, 2024
@github-actions github-actions bot requested review from G-XD and oowl January 24, 2024 04:37
@hoslo
Copy link
Contributor

hoslo commented Jan 24, 2024

Oh, fixes #xxx will close a pr directly...

Yes, I should just paste it.

@suyanhanx
feat(services/koofr): set test for koofr
6becac4 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix env var name
c6a4aed 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix feature flag in bindings
12bd406 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix setup config
77dba32 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix skip condition
986897d 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix skip condition
4ba6e7b 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
fix format
c407eb6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
remove test-threads limit
b00bae5 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
Xuanwo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a0a917f into main Jan 24, 2024
233 checks passed
@Xuanwo Xuanwo deleted the koofr-test branch January 24, 2024 05:26
@morristai morristai mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@morristai morristai Awaiting requested review from morristai

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

@G-XD G-XD Awaiting requested review from G-XD

@oowl oowl Awaiting requested review from oowl

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suyanhanx @hoslo @Xuanwo