Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bindings/python): sync writer exit close raise error #4127

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(bindings/python): sync writer exit close raise error #4127

merged 1 commit into from
Feb 1, 2024

Conversation

suyanhanx
Copy link
Member

close #4124

@suyanhanx
fix(bindings/python): sync writer exit close raise error
568aa54 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx requested a review from Xuanwo February 1, 2024 13:06
@github-actions github-actions bot requested review from morristai and oowl February 1, 2024 13:06
Xuanwo
Xuanwo approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit f4a3027 into main Feb 1, 2024
33 checks passed
@Xuanwo Xuanwo deleted the py-sync-writer-exit-close branch February 1, 2024 13:36
@Xuanwo Xuanwo mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@morristai morristai Awaiting requested review from morristai

@oowl oowl Awaiting requested review from oowl

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binding/python: How to return error in __exit__
2 participants
@suyanhanx @Xuanwo