chore: Bump package versions #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
requested review from
PsiACE,
messense,
Zheaoli,
suyanhanx,
oowl,
tisonkun and
silver-ymz
as code owners
tisonkun
approved these changes
Aug 9, 2024
Bicheka
added a commit
to Bicheka/opendal
that referenced
this pull request
Aug 11, 2024
This commit addresses the issue raised in the pull request apache#4989, where the `read()` operation did not always return the expected content length. Changes include: - Implementing a loop to gather all content chunks until EOF. - Performing the assertion after the entire content has been read. This ensures that the test passes stably by correctly handling cases where `read()` may not return the full content in one go.
Xuanwo
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Fix #4990 guarantees read until EOF * Address code review feedback for solving issue #4990 * Fix: Ensure full content is read before performing assertions This commit addresses the issue raised in the pull request #4989, where the `read()` operation did not always return the expected content length. Changes include: - Implementing a loop to gather all content chunks until EOF. - Performing the assertion after the entire content has been read. This ensures that the test passes stably by correctly handling cases where `read()` may not return the full content in one go. * address pr code review comment * addressed pr code review by deleting requested code in my pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4982.
Rationale for this change
This PR will bump packages as the following:
What changes are included in this PR?
Are there any user-facing changes?