-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support NebulaGraph #5116
Conversation
8d5dae0
to
7180639
Compare
Test results are as follows:
|
Hi, @GG2002. It might take us a while to complete the communication. Would you like to split this PR into parts so we can merge some of them first? I believe we can add the builder, config first without introduce the client impl in. |
It's ok. |
bcc646c
to
5388a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, thank you @GG2002 a lot for working on this!
Signed-off-by: feathercyc <feathercyc@163.com>
5388a61
to
2bfc4b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Which issue does this PR close?
Closes #4553.
Rationale for this change
What changes are included in this PR?
Support
read
,write
,list
,delete
ops on NebulaGraph.To access NebulaGraph, users must provide the
username
andpassword
for NebulaGraph, as well as specify thespace
,tag
, and thekey field
andvalue field
of thetag
.Since each
vertex
in NebulaGraph must have a unique ID(called VID), but NebulaGraph lacks a self-incrementing ID, the unique IDs are generated using the Snowflake algorithm. Additionally, theset
operation involves firstdelete
existing originalvertex
, followed by inserting a newvertex
.NebulaGraph does not support the Blob type, hence
Base64+string
type is employed for file access. If it's supported in the future, just removeBase64
.Are there any user-facing changes?
No(?)