Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run object_store tests in CI #5268

Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore: run object_store tests in CI #5268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af0712d
chore: include object_store tests in ci
jorgehermo9 Nov 1, 2024
4f0ba3e
test: fix broken doctest
jorgehermo9 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci_integration_object_store.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,7 @@ jobs:
- name: Cargo clippy
working-directory: integrations/object_store
run: cargo clippy --all-targets --all-features -- -D warnings

- name: Cargo test
working-directory: integrations/object_store
run: cargo test
15 changes: 5 additions & 10 deletions integrations/object_store/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,11 @@
//!
//! #[tokio::main]
//! async fn main() {
//! let builder = S3::from_map(
//! vec![
//! ("access_key".to_string(), "my_access_key".to_string()),
//! ("secret_key".to_string(), "my_secret_key".to_string()),
//! ("endpoint".to_string(), "my_endpoint".to_string()),
//! ("region".to_string(), "my_region".to_string()),
//! ]
//! .into_iter()
//! .collect(),
//! ).unwrap();
//! let builder = S3::default()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that it is an outdated doc test. Change inspired from https://docs.rs/opendal/latest/opendal/services/struct.S3.html#basic-setup

//! .access_key_id("my_access_key")
//! .secret_access_key("my_secret_key")
//! .endpoint("my_endpoint")
//! .region("my_region");
//!
//! // Create a new operator
//! let operator = Operator::new(builder).unwrap().finish();
Expand Down
15 changes: 5 additions & 10 deletions integrations/object_store/src/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,11 @@ use tokio::sync::{Mutex, Notify};
///
/// #[tokio::main]
/// async fn main() {
/// let builder = S3::from_map(
/// vec![
/// ("access_key".to_string(), "my_access_key".to_string()),
/// ("secret_key".to_string(), "my_secret_key".to_string()),
/// ("endpoint".to_string(), "my_endpoint".to_string()),
/// ("region".to_string(), "my_region".to_string()),
/// ]
/// .into_iter()
/// .collect(),
/// ).unwrap();
/// let builder = S3::default()
/// .access_key_id("my_access_key")
/// .secret_access_key("my_secret_key")
/// .endpoint("my_endpoint")
/// .region("my_region");
///
/// // Create a new operator
/// let operator = Operator::new(builder).unwrap().finish();
Expand Down
Loading