feat(core/services-gcs): support user defined metadata #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgehermo9
commented
Nov 3, 2024
jorgehermo9
commented
Nov 3, 2024
Thank you, @jorgehermo9, for working on this. We do have tests for GCS, but GitHub has security reasons for not allowing PRs from forks to use them. (This can be addressed once you become an OpenDAL committer!) I will try to trigger the test for you. |
jorgehermo9
commented
Nov 3, 2024
Xuanwo
reviewed
Nov 3, 2024
jorgehermo9
commented
Nov 4, 2024
jorgehermo9
commented
Nov 4, 2024
Xuanwo
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Thank you @jorgehermo9, most changes LGTM, I will trigger a CI for it.
|
See #5284 |
|
Nice work!
|
17 tasks
|
Hi @Xuanwo so nice! Thank you very much. I'm open for any other suggestions! |
Xuanwo
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4842
Please do not merge yet, I'm not sure this works.
I didn't see the CI for GCS behaviour tests. Im not sure that this PR is ok, as I do not have a GCP account and couldn't find out how to test it locally. Tried it with https://github.com/fsouza/fake-gcs-server and I also couldn't figure it out. Also, I can't get the gcs behavior tests running in local
Is the behaviour test plan ok? https://github.com/apache/opendal/actions/runs/11652657364/job/32444123433#step:3:39
It seems that the gcs service is being filtered out in this condition
opendal/.github/scripts/test_behavior/plan.py
Line 59 in 330bd74
Maybe a maintainer has to manually run that check?