Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue : #5408 #5442

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue : #5408 #5442

wants to merge 5 commits into from

Conversation

Yashika-code
Copy link

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Xuanwo
Copy link
Member

Xuanwo commented Dec 24, 2024

Hi @Yashika-code, thank you so much for your enthusiasm. This is your first contribution to OpenDAL, and it feels like this PR marks the very beginning of your open-source journey. So, please allow me to write a detailed letter to welcome you and assist you in completing your first contribution.


First and foremost, we are a community made up of people like you. We learn from one another and work together to implement the vision of our project: one layer, all storage. We are not NPCs simply publishing tasks or maintaining a basic task list. Instead, we encourage communication among members—asking, answering, and learning from each other. When we leave a review comment, it doesn't mean you're wrong; it simply highlights areas where we can improve together. So, please avoid repeatedly opening and closing PRs—just push your changes to the same branch.

For more general guidance on contributing to open source projects, you can visit: https://opensource.guide/how-to-contribute/#opening-a-pull-request

Returning to this PR, to get it merged, we need the following things:

  • Change the PR's title to reflect its purpose.
  • Update the PR description to accurately represent its content: why, what, how, etc.
  • Add comments for the newly added API.
  • Add tests for the newly added API.

Please let me know if you need any assistance.


Wishing you a wonderful open-source journey!

@Yashika-code
Copy link
Author

Yashika-code commented Dec 24, 2024

Thank you so much sir .

@Yashika-code
Copy link
Author

Yashika-code commented Dec 24, 2024

Now , @Xuanwo What's the tasks has been remaining in this pr ?

@Xuanwo
Copy link
Member

Xuanwo commented Dec 24, 2024

Now , @Xuanwo What's the tasks has been remaining in this pr ?

Hi, the required tasks are listed at #5442 (comment). Please double-check.

@Yashika-code
Copy link
Author

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Zheaoli Zheaoli closed this Dec 24, 2024
@Zheaoli Zheaoli reopened this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants