Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception name in python #5453

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Dec 25, 2024

Which issue does this PR close?

Closes #5452

Rationale for this change

after this patch:

Traceback (most recent call last):
  File "C:\Users\Trim21\proj\test\f.py", line 14, in <module>
    op.read("non-exists-path")
opendal.exceptions.NotFound: NotFound (permanent) at stat, context: { service: redis, path: non-exists-path } => kv doesn't have this path

What changes are included in this PR?

Are there any user-facing changes?

Yes, name in user exception message

@trim21 trim21 changed the title fix exception name in python fix: exception name in python Dec 25, 2024
@messense
Copy link
Member

I'm not sure if we want to do a breaking change in a bugfix PR, can you split it into two PRs, one for the bugfix, another for the renames? Thanks!

@trim21
Copy link
Contributor Author

trim21 commented Dec 25, 2024

I'm not sure if we want to do a breaking change in a bugfix PR, can you split it into two PRs, one for the bugfix, another for the renames? Thanks!

Would you mind explain why it's a breaking change? There is no actually rename in python level but only class qualname in error message changed.

@messense
Copy link
Member

Oh right, I missed the exception_module.add part.

@messense messense merged commit 5ad7e0b into apache:main Dec 25, 2024
60 checks passed
@trim21 trim21 deleted the python-error-name branch December 25, 2024 01:25
@messense
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: python exception module name and class name both don't match
2 participants