Add the support to specify the version of the binaries #251
Conversation
This PR changes the task name from release to releaseBinaries in order to make it consistent in the release process. It also adds packageVersion as a parameter to specify the version of the binaries to be released. Partially-closes: apache/openwhisk-release#9
houshengbo
force-pushed
the
add-binary-build
branch
from
114279a
to
6d93a52
Compare
|
@jonpspri Please help me review this PR, thanks. |
build.gradle
Outdated
| @@ -61,6 +61,7 @@ class OpenWhiskPlatform { | |||
| The 'zipFileName' property is the root file name to use for archives. | |||
| */ | |||
| static String zipFileName | |||
| static String packageVersion | |||
There was a problem hiding this comment.
I think this belongs a project extension rather than an attribute of OpenWhiskPlatform. Platform really is intended to deal solely with the process/os aspects of the build and is less volatile than version.
Additional thought on why this is important — I think it would be a Bad Idea (but possible and implicitly supported) to build different version numbers for different architectures if we set the packageVersion for each platform.
That means taking off the OpenWhisk. and p. below.
build.gradle
Outdated
| @@ -121,6 +122,10 @@ OpenWhiskPlatform.zipFileName = | |||
| System.env['zip_file_name'] ?: | |||
| (rootProject.findProperty('zipFileName') ?: 'OpenWhisk_CLI') | |||
|
|
|||
| OpenWhiskPlatform.packageVersion = | |||
| System.env['packageVersion'] ?: | |||
| (rootProject.findProperty('packageVersion') ?: 'latest') | |||
There was a problem hiding this comment.
Per my comment above, this can become project.ext.packageVersion =. Also, I’m not sure I’d use an environment variable because it hides the “I’m building a release now” from the command line. If we have a variable set in a Travis build, we should pass it on the command line as the build parameter (as you provide here).
There was a problem hiding this comment.
Done. I remove the configuration as a system env.
|
@jonpspri Thank you. I have changed this PR based on the comments. |
|
LGTM |
This PR changes the task name from release to releaseBinaries in
order to make it consistent in the release process. It also adds
packageVersion as a parameter to specify the version of the binaries
to be released.
Partially-closes: apache/openwhisk-release#9