Openwhisk proxy #147
Merged
Openwhisk proxy #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 99.23% 98.99% -0.25%
==========================================
Files 14 14
Lines 393 397 +4
==========================================
+ Hits 390 393 +3
- Misses 3 4 +1
Continue to review full report at Codecov.
|
jthomas
requested changes
Feb 21, 2019
There was a problem hiding this comment.
This looks excellent @karanrk - thanks for doing this! This will be a great addition to the SDK.
Two small things so we can merge....
- Add a unit test to the client module file to verify the new options.
- Add documentation to the README after
user-agentsection to describe new feature.
|
@jthomas Let me know if any more changes are required from my side. |
jthomas
approved these changes
Feb 22, 2019
|
Awesome work @karanrk - Thanks for doing this! We'll need to publish a new version of the SDK now. I'll open an issue to do that. |
|
Let’s make sure we do a proper Apache release 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request solves the problem of openwhisk client not able to make server requests if client is behind firewall. The client uses needle to package the parameters and options to make a HTTP request to the server, this PR uses a proxy-agent to pass through the firewall and connect to openwhisk sdk.
Files Edited : client.js and package.json