Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Description field in corresponding entities #1057

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

alvarolopez
Copy link
Contributor

The Description field should be supported across all entities, as it is
included in the "Shared Entity Schema".

Fixes: #548

The Description field should be supported across all entities, as it is
included in the "Shared Entity Schema".

Fixes: apache#548
@mrutkows
Copy link
Contributor

@alvarolopez I believe we held off placing support for it in the client since the Description is not yet recognized or stored at the server. This would have to be done by using the object's metadata field (to not alter server schema) and corresponding changes to the Client / CLI to allow them to be read/written as well.

@alvarolopez
Copy link
Contributor Author

@mrutkows I believe that adding the description field worked for me, I need to check and keep you posted, as I remember some fields not working as you say.

@mrutkows
Copy link
Contributor

@alvarolopez I will merge this change allowing the "Description" to be part of the schema, but to be clear, any description data will not be respected at the server (i.e., not stored directly or in Annotation metadata) without further changes in wskdeploy to read/write this info. to the Annotations (OR get the server-side schema to allow Description to be a key on the actual Rule, Trigger, etc. entities directly).

@alvarolopez
Copy link
Contributor Author

@mrutkows I forgot to reply to you: we're fine with not storing the description at server-side, but having it as part of the schema so that every action can include a description. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description field/key is not supported for Rule entity
2 participants