Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet core 3.1 action support #1098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woutersterp
Copy link

I think this is the only thing to be added for dotnet core 3.1 support right?

I think this is the only thing to be added for dotnet core 3.1 support right?
@mrutkows
Copy link
Contributor

mrutkows commented Mar 2, 2021

@woutersterp Please rebase and add some "helloworld" style unit and integration tests (manifests) to verify support in our CI/CD process (Travis). Please reference the work done for the updated Rust runtime in this PR to get an idea of what the balance of work is needed here: #1119

@@ -480,6 +480,21 @@ var RUNTIME_DETAILS = []byte(`{
"attachmentName": "codefile",
"attachmentType": "text/plain"
}
},
{
"kind": "dotnet:3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests and perhaps an integration test to validate support in our CI/CD process. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants