Upgraded Go 1.15

[huydoan2]

No description provided.

[mrutkows]

It appears some of the type conversions in go 1.15 now behave slightly differently (perhaps) in error responses generated.

# github.com/apache/openwhisk-wskdeploy/parsers

parsers/manifest_parser_test.go:1742:21: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
parsers/manifest_parser_test.go:1743:19: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
parsers/manifest_parser_test.go:1751:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
parsers/manifest_parser_test.go:1752:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
parsers/manifest_parser_test.go:1771:22: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
parsers/manifest_parser_test.go:1772:20: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

[mrutkows]

Here is the code area of interest for the first error (1742,1743):

m, err := testReadAndUnmarshalManifest(t, "../tests/dat/manifest_data_unmarshal_packages.yaml")

	// Unmarshal reads/parses manifest data and sets the values of YAML
	// And returns an error if parsing a manifest data fails
	if err == nil {
		expectedResult := string(2)  // <= 1742
		actualResult := string(len(m.Packages)) // <== 1743
		assert.Equal(t, expectedResult, actualResult, "Expected 2 packages but got "+actualResult)

So it appears the string constructor now fails given a uint and requires us to use sprintf to construct the string provided to the assert.

[huydoan2]

Notes about Go 1.15 and string(x): https://golang.org/doc/go1.15#vet

[mrutkows]

Thanks for addressing the change of string(n) behavior in our unit tests.