Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the gradle build to use the gogradle plugin #812

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented Mar 21, 2018

This PR applies the gogradle plugin to build the binaries of openwhisk
wskdeploy.

Partially-closes: apache/openwhisk-release#9

@houshengbo houshengbo added the wip label Mar 21, 2018
@houshengbo houshengbo force-pushed the change-gradle-build branch 10 times, most recently from ac0e45c to df8f2d6 Compare March 22, 2018 14:51
@houshengbo houshengbo removed the wip label Mar 22, 2018
@@ -77,7 +77,7 @@
},
{
"ImportPath": "github.com/mattn/go-isatty",
"Rev": "66b8e73f3f5cda9f96b69efd03dd3d7fc4a5cdb8"
"Rev": "a5cdd64afdee435007ee3e9f6ed4684af949d568"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any other deps we should be updating at this time to match build.gradle versions?

Copy link
Author

@houshengbo houshengbo Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this is the only one i found out to change. Anyhow, I will revert it.

}
}

task releaseBinaries(type: Tar, dependsOn: [individualArchives, index]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we run a tagged release PR to test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we have to merge it and test :-(

@mrutkows mrutkows added the wip label Mar 22, 2018
@houshengbo houshengbo force-pushed the change-gradle-build branch 3 times, most recently from e9cc65b to c1046dd Compare March 22, 2018 16:19
This PR applies the gogradle plugin to build the binaries of openwhisk
wskdeploy.

Partially-closes: apache/openwhisk-release#9
Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can test the tagged release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package the binaries of each repo in need
2 participants