Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade akka libs #5491

Closed
wants to merge 4 commits into from
Closed

upgrade akka libs #5491

wants to merge 4 commits into from

Conversation

pjfanning
Copy link

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@pjfanning
Copy link
Author

Error:  /home/runner/work/openwhisk/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scala:177: method create in trait GraphApply is deprecated (since 3.6.26): Use createGraph instead
Error:  /home/runner/work/openwhisk/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/SplunkLogStore.scala:183: method dropNew in object OverflowStrategy is deprecated (since 2.6.11): Use Source.queue instead
Error:  /home/runner/work/openwhisk/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/database/Batcher.scala:67: method dropNew in object OverflowStrategy is deprecated (since 2.6.11): Use Source.queue instead
Error:  /home/runner/work/openwhisk/openwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/database/StoreUtils.scala:87: method create in trait GraphApply is deprecated (since 4.6.36): Use createGraph instead

downgrade some akka libs because scala 2.12 is not supported on newer version

avoid using package private Akka S3Exception class

add EOL

copy old S3Exception code from Alpakka

format

scalafmt

some compile issues

Update FunctionPullingContainerProxy.scala
@pjfanning
Copy link
Author

Broken test:

org.apache.openwhisk.common.etcd.EtcdLeaderShipUnitTests > Etcd LeaderShip client should be failed to elect leader with provided lease STANDARD_ERROR
    Sep 21, 2024 6:10:15 PM io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
    SEVERE: *~*~*~ Channel ManagedChannelImpl{logId=7, target=etcd} was not shutdown properly!!! ~*~*~*
        Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
    java.lang.RuntimeException: ManagedChannel allocation site
    	at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:93)
    	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:53)
    	at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:44)
    	at io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:517)
    	at com.ibm.etcd.client.EtcdClient.<init>(EtcdClient.java:284)
    	at com.ibm.etcd.client.EtcdClient$Builder.build(EtcdClient.java:215)
    	at org.apache.openwhisk.common.etcd.EtcdLeaderShipUnitTests$MockEtcdLeadershipApi.<init>(EtcdLeaderShipUnitTests.scala:68)
    	at org.apache.openwhisk.common.etcd.EtcdLeaderShipUnitTests$$anon$2.<init>(EtcdLeaderShipUnitTests.scala:134)
    	at org.apache.openwhisk.common.etcd.EtcdLeaderShipUnitTests.$anonfun$new$2(EtcdLeaderShipUnitTests.scala:134)

@style95
Copy link
Member

style95 commented Oct 14, 2024

@pjfanning
Do you have any updates on this?
Was this blocked because of the EtcdLeaderShipUnitTests?

@pjfanning
Copy link
Author

I'll close this. I don't have time to work on this.

@pjfanning pjfanning closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants