Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORC-484 Extend PhysicalWriter to support encryption #402

Merged
merged 1 commit into from
Jun 25, 2019
Merged

ORC-484 Extend PhysicalWriter to support encryption #402

merged 1 commit into from
Jun 25, 2019

Conversation

omalley
Copy link
Contributor

@omalley omalley commented Jun 17, 2019

The PhysicalWriter and its implementation need a couple of changes:

  • Stripe & file statistics need to be handled differently to support encryption. There is now a method on the WriterContext that allows setting the stripe & file statistics.
  • getFileBytes needs to know which encryption variant is being asked about
  • I generalized PhysicalWriter.getCompressionCodec to getStreamOptions.
  • The PhysicalFsWriter now tracks each encryption variant and handles them separately.
  • StreamName gets the encryption variant.
  • TreeWriter gets a new method for getting the current file stats.
  • Add WriterEncryptionVariant and WriterEncryptionKey to keep encryption information.

omalley added a commit to omalley/orc that referenced this pull request Jun 17, 2019
@omalley
ORC-484: Update PhysicalWriter to support encryption.
b44f37f 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
omalley added a commit to omalley/orc that referenced this pull request Jun 17, 2019
@omalley
ORC-484: Update PhysicalWriter to support encryption.
2ea7f0c 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley
ORC-484: Update PhysicalWriter to support encryption.
df79ad1 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley omalley merged commit df79ad1 into apache:master Jun 25, 2019
zratkai pushed a commit to zratkai/orc that referenced this pull request Jun 20, 2024
@omalley
CDPD-45931: ORC-484: Update PhysicalWriter to support encryption.
3c4c1d7 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
Change-Id: I67ebedc34bf08811a369b2da2050c1664b787fb6
zratkai pushed a commit to zratkai/orc that referenced this pull request Jun 20, 2024
@omalley
CDPD-45931: ORC-484: Update PhysicalWriter to support encryption.
f4807cb 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
Change-Id: I97cfa698a6f3fcadcd202adbb2f6a3f26e696308
zratkai pushed a commit to zratkai/orc that referenced this pull request Jun 20, 2024
@omalley
CDPD-45931: ORC-484: Update PhysicalWriter to support encryption.
c18bf3b 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
Change-Id: I97cfa698a6f3fcadcd202adbb2f6a3f26e696308
zratkai pushed a commit to zratkai/orc that referenced this pull request Jun 20, 2024
@omalley
CDPD-45931: ORC-484: Update PhysicalWriter to support encryption.
c97f4d2 
Fixes apache#402

Signed-off-by: Owen O'Malley <omalley@apache.org>
Change-Id: I4e1dbd8b81505a66af45ebb1abe49537a4842457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omalley