-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-676. Add getRawDataSizeFromColIndices back to ReaderImpl #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you review this please, @omalley ? |
Could you review this, @wgtmac ? |
wgtmac
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Thank you so much, @wgtmac ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 28, 2020
For Apache Orc 1.6.6, I cherry-picked to branch-1.6 and pushed after testing. |
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
…mpl (apache#555) ORC-676: Add getRawDataSizeFromColIndices back to ReaderImpl This closes apache#555 Change-Id: I1aa67c7d0e85e4bf9a13e8a3667e3a7bdfe960d0
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
… ReaderImpl (apache#555)" This reverts commit 7e4d514. Change-Id: I95b774f2f5b2e929f549409590958f32c79305ff
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
…mpl (apache#555) ORC-676: Add getRawDataSizeFromColIndices back to ReaderImpl This closes apache#555 Change-Id: I07c66ee109e48b81715ae2b6b7845191cc89b98d
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
…into cdw-master * changes: CDPD-45931: ORC-661: Use ChronoLocalDate and day of epoch instead of java's Date for column statistics. CDPD-45931: ORC-398 col stats list map (apache#395) CDPD-45931: ORC-705: Predicate evaluation should take into account writer calendar (apache#588) CDPD-45931: ORC-706: Put back DataReaderProperties default maxDiskRangeChunkLimit CDPD-45931: ORC-685: Add `ReaderImpl.extractFileTail` back (apache#570) CDPD-45931: ORC-676. Add getRawDataSizeFromColIndices back to ReaderImpl (apache#555) CDPD-45931: ORC-671: Add OrcTail.getStripeStatistics back for backward compatiblility CDPD-45931: ORC-669: Reduce breaking changes in ReaderImpl.java (apache#547) Change-Id: If1e18dadec1cb9ad9f08b20d4f031a9b18afed77 CDPD-45931: ORC-621: Fix reader for empty positions list in first row index entry. CDPD-45931: ORC-548: Fix Java InStream to work with BufferChunks that don't start at the stream. CDPD-45931: ORC-520: Fix file merging for column encryption. CDPD-45931: ORC-529: Allow configuration and table properties to control encryption. CDPD-45931: ORC-487: Refactor stripe planning to a new class StripePlanner. CDPD-45931: ORC-523: Update ReaderImpl to work with column encryption. CDPD-45931: ORC-516: Update InStream for column compression. CDPD-45931: ORC-486: Add column entryption to the TreeWriters. CDPD-45931: ORC-484: Update PhysicalWriter to support encryption. CDPD-45931: ORC-509: Fix the KeyProvider to match the current spec. CDPD-45931: ORC-510: Cleanup API for StreamOptions and CompressionCodec.Options CDPD-45931: ORC-485. Add API to write encrypted files. CDPD-45931: ORC-483 Update protobuf for column encryption. CDPD-45931: ORC-421: Separate compression options from the CompressionCodec. CDPD-45931: ORC-251: Extend InStream and OutStream to support encryption.
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
… ReaderImpl (apache#555)" This reverts commit 8e23c77. Change-Id: Idfcfbe7ee90a6c1630d51e1c118b733d1cddbca2
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
…mpl (apache#555) ORC-676: Add getRawDataSizeFromColIndices back to ReaderImpl This closes apache#555 Change-Id: I07c66ee109e48b81715ae2b6b7845191cc89b98d
zratkai
pushed a commit
to zratkai/orc
that referenced
this pull request
Jun 20, 2024
…mpl (apache#555) ORC-676: Add getRawDataSizeFromColIndices back to ReaderImpl This closes apache#555 Change-Id: I0f5f7fc5014f5943d28cea85768e06b9d816f9a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
getRawDataSizeFromColIndices
back toReaderImpl
.Why are the changes needed?
This helps the migration path from Apache Orc 1.5 to 1.6+
How was this patch tested?
Pass the newly added test case.