-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-747: Abstract Dictionary interface and refactoring #637
Conversation
Thank you for making a PR, @autumnust . It seems that many failure. Could you test it locally first?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle ping, @autumnust . |
Sorry I got preempted by some other thing last week. I will get back to fixing the failure in Github Action ASAP. Thanks @dongjoon-hyun for your review in first round. |
Address reviewer's comments II
What changes were proposed in this pull request?
This PR contains the very first part to make the implementation of dictionary used for encoding pluggable, by introducing an interface
Dictionary
. The subsequent PR will add HashTable-based Dictionary implementation and compare with the existing RB-tree based dictionary.For reviewers:
Dictionary
class isn't added with generic type declaration (e.g. we could use a generic typeT
to replaceText
). Please let me know if that's necessary to add.Why are the changes needed?
How was this patch tested?
Since this is mostly a refactoring, it is just passing all existing unit tests.