Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: protoc add os.detected.classifier properties for MAC and windows #328

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: protoc add os.detected.classifier properties for MAC and windows #328

merged 1 commit into from
Apr 9, 2024

Conversation

sadadw1
Copy link
Contributor

@sadadw1 sadadw1 commented Apr 9, 2024

fix: protoc add os.detected.classifier properties for MAC and windows #327

jifengzhilong
jifengzhilong approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jifengzhilong jifengzhilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

wtt40122
wtt40122 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@wtt40122 wtt40122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@wtt40122 wtt40122 merged commit cd55fb4 into apache:master Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtt40122 wtt40122 wtt40122 approved these changes

@jifengzhilong jifengzhilong jifengzhilong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadadw1 @jifengzhilong @wtt40122