Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve code layering of ozhera-prometheus-agent module #437

Merged
merged 3 commits into from
Sep 6, 2024
Merged

refactor: improve code layering of ozhera-prometheus-agent module #437

merged 3 commits into from
Sep 6, 2024

Conversation

psxjoy
Copy link
Contributor

@psxjoy psxjoy commented Sep 2, 2024

Associate issue:
fix #434

refactor module:
ozhera-prometheus-agent

Changes made:

  1. Separated the service layer interfaces and their implementation classes in the ozhera-prometheus-agent module.
  2. Corrected spelling errors.
  3. Added comments to certain interfaces.

wodiwudi
wodiwudi approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@wodiwudi wodiwudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@wodiwudi wodiwudi requested a review from sadadw1 September 3, 2024 07:36
sadadw1
sadadw1 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@sadadw1 sadadw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@psxjoy
Copy link
Contributor Author

psxjoy commented Sep 3, 2024

It looks like there's a problem with the Lint Commit Messages workflow, showing a lack of permission to run, which is preventing the code from merging automatically.Should I submit a new PR, or will you look into this workflow issue?

看上去 Lint Commit Messages 这个 workflow有问题，提示没有权限运行，导致无法自动合并。我需要重新提交PR吗？或者你们会排查这个 workflow。 @wodiwudi @sadadw1

@wodiwudi wodiwudi merged commit 422dc63 into apache:master Sep 6, 2024
2 checks passed
@wodiwudi
Copy link
Contributor

wodiwudi commented Sep 6, 2024

Lint Commit workflow has been fixed and can now pass

@psxjoy psxjoy deleted the opt-ozhera-prometheus-agent branch September 10, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadadw1 sadadw1 sadadw1 approved these changes

@wodiwudi wodiwudi wodiwudi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Optimizing] Improve code layering of ozhera-prometheus-agent module
3 participants
@psxjoy @wodiwudi @sadadw1