Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: compile project with new groupId #472 #473

Merged
merged 2 commits into from
Sep 13, 2024
Merged

refactor: compile project with new groupId #472 #473

merged 2 commits into from
Sep 13, 2024

Conversation

goodjava
Copy link
Contributor

[enhancement] compile project with new groupId #472

@shanwb shanwb requested review from shanwb and wodiwudi September 13, 2024 08:35
shanwb
shanwb previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@shanwb shanwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LGTM

wodiwudi
wodiwudi previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@wodiwudi wodiwudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@wodiwudi wodiwudi changed the title [enhancement] compile project with new groupId #472 enhancement: compile project with new groupId #472 Sep 13, 2024
@wodiwudi wodiwudi changed the title enhancement: compile project with new groupId #472 refactor: compile project with new groupId #472 Sep 13, 2024
@goodjava goodjava dismissed stale reviews from wodiwudi and shanwb via 418a96e September 13, 2024 08:39
wodiwudi
wodiwudi approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@wodiwudi wodiwudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

shanwb
shanwb approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@shanwb shanwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LGTM

@wodiwudi wodiwudi merged commit 172610b into apache:master Sep 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wodiwudi wodiwudi wodiwudi approved these changes

@shanwb shanwb shanwb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goodjava @shanwb @wodiwudi