Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compile with new groupId (#472) #480

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

shanwb
Copy link
Contributor

@shanwb shanwb commented Sep 14, 2024

No description provided.

@shanwb shanwb requested review from wtt40122 and sadadw1 September 14, 2024 10:59
sadadw1
sadadw1 previously approved these changes Sep 14, 2024
Copy link
Contributor

@sadadw1 sadadw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

wtt40122
wtt40122 previously approved these changes Sep 14, 2024
Copy link
Contributor

@wtt40122 wtt40122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@shanwb shanwb dismissed stale reviews from sadadw1 and wtt40122 September 14, 2024 11:34

The merge-base changed after approval.

@shanwb shanwb changed the title Master 0914 003refactor: compile with new groupId (#472) refactor: compile with new groupId (#472) Sep 14, 2024
@wtt40122 wtt40122 self-requested a review September 14, 2024 11:37
@shanwb shanwb requested a review from sadadw1 September 14, 2024 11:38
Copy link
Contributor

@sadadw1 sadadw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@sadadw1 sadadw1 merged commit 45ca0e2 into apache:master Sep 14, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants