Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary shard updates while shutting down #1342

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Avoid unnecessary shard updates while shutting down #1342

merged 2 commits into from
Jun 4, 2024

Conversation

nvollmar
Copy link
Contributor

Refs #1341

@pjfanning
Copy link
Contributor

looks sensible to me - let's see what other reviewers say

When we get a fix in, we might want to backport it to 1.0.x. I think we should make a 1.0.3 release in the next few weeks.

@nvollmar
Copy link
Contributor Author

Would be good to have that in 1.0.3

@pjfanning pjfanning added this to the 1.1.0-M2 milestone May 24, 2024
samueleresca
samueleresca approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@samueleresca samueleresca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

He-Pin
He-Pin approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Roiocam
Roiocam approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Roiocam Roiocam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

ShardUpdate will only notify Shard to start detecting the passivation. This is seems like a harmless change.

@nvollmar nvollmar merged commit 92b38e7 into main Jun 4, 2024
18 checks passed
@nvollmar nvollmar deleted the fix-unhandled-shardsupdated branch June 4, 2024 05:41
nvollmar added a commit that referenced this pull request Jun 4, 2024
@nvollmar
Avoid unnecessary shard updates while shutting down (#1342)
163f6e8 
* Avoid unnecessary shard updates while shutting down

* Avoid re-creating the same message for each shard
nvollmar added a commit that referenced this pull request Jun 4, 2024
@nvollmar
Avoid unnecessary shard updates while shutting down (#1342) (#1353)
4f77c81 
* Avoid unnecessary shard updates while shutting down

* Avoid re-creating the same message for each shard
@pjfanning pjfanning added the release notes Need to release note label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roiocam Roiocam Roiocam approved these changes

@samueleresca samueleresca samueleresca approved these changes

@He-Pin He-Pin He-Pin approved these changes

@raboof raboof Awaiting requested review from raboof

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@danischroeter danischroeter Awaiting requested review from danischroeter

Assignees
No one assigned
Labels
release notes Need to release note
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nvollmar @pjfanning @He-Pin @samueleresca @Roiocam