Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Adaptive Server Selection to penalize servers returning server side exceptions #14029

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kiruphabalu
Copy link

@kiruphabalu kiruphabalu commented Sep 18, 2024

  • Currently if server response has exceptions they are not considered and the latency is set to time taken to receive response. This potentially ranks servers with underlying issues better. So the algorithm would prefer these servers.
  • With this change, the response from server is parsed and if there are server side exceptions the latency of the server is set to max as timeout ms. This will rank the server lower than healthy servers.

Unit test cases

  • Response with no exception will have latency set to response time
  • Response with client exceptions will have latency set to response time
  • Response with at least one server exception will have latency set to timeout ms

PINOT-19249 Adding more unit test cases

PINOT-19249 Addressing comments and changing code to cover edge cases

PINOT-19249 Code changes based on comments

PINOT-19249 Fixing test cases for ADSS penalizing servers with exceptions
@vvivekiyer vvivekiyer changed the title Rank servers with exceptions lower in ADSS Improve Adaptive Server Selection to penalize servers returning server side exceptions Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.04%. Comparing base (59551e4) to head (339afd1).
Report is 1064 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pinot/core/transport/AsyncQueryResponse.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14029      +/-   ##
============================================
+ Coverage     61.75%   65.04%   +3.29%     
- Complexity      207     1534    +1327     
============================================
  Files          2436     2564     +128     
  Lines        133233   140753    +7520     
  Branches      20636    21608     +972     
============================================
+ Hits          82274    91555    +9281     
+ Misses        44911    42456    -2455     
- Partials       6048     6742     +694     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 64.99% <84.61%> (+3.28%) ⬆️
java-21 64.93% <84.61%> (+3.30%) ⬆️
skip-bytebuffers-false 65.01% <84.61%> (+3.26%) ⬆️
skip-bytebuffers-true 64.91% <84.61%> (+37.18%) ⬆️
temurin 65.04% <84.61%> (+3.29%) ⬆️
unittests 65.04% <84.61%> (+3.29%) ⬆️
unittests1 56.53% <84.61%> (+9.64%) ⬆️
unittests2 35.02% <0.00%> (+7.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiruphabalu kiruphabalu marked this pull request as ready for review September 19, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants