update the sorting logic from cardinality to container count - Draft #14050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandheritage
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14050 +/- ##
============================================
+ Coverage 61.75% 65.05% +3.30%
- Complexity 207 1533 +1326
============================================
Files 2436 2564 +128
Lines 133233 140765 +7532
Branches 20636 21608 +972
============================================
+ Hits 82274 91577 +9303
+ Misses 44911 42450 -2461
- Partials 6048 6738 +690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -107,7 +107,7 @@ public BlockDocIdIterator iterator() { | |||
|
|
|||
| // evaluate the bitmaps in the order of the lowest matching num docIds comes first, so that we minimize the number | |||
| // of containers (range) for comparison from the beginning, as will minimize the effort of bitmap AND application | |||
| bitmapBasedDocIdIterators.sort(Comparator.comparing(x -> x.getDocIds().getCardinality())); | |||
| bitmapBasedDocIdIterators.sort(Comparator.comparing(x -> x.getDocIds().getContainerCount())); | |||
There was a problem hiding this comment.
can you also update the comment just above?
There was a problem hiding this comment.
Will make that change - Looking for a way to benchmark this change. Can you recommend something ? Do we have a common tool to do that ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread : https://apache-pinot.slack.com/archives/C013WKLT5T7/p1726721380906609
Instructions:
featurebugfixperformanceuibackward-incompatrelease-notes(**)(*) Other labels to consider:
testingdependenciesdockerkubernetesobservabilitysecuritycode-styleextension-pointrefactorcleanup(**) Use
release-noteslabel for scenarios like: