Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] error handling for new partition producer creation failure #319

Closed
1 of 2 tasks
erobot opened this issue Sep 20, 2023 · 0 comments · Fixed by #378
Closed
1 of 2 tasks

[Bug] error handling for new partition producer creation failure #319

erobot opened this issue Sep 20, 2023 · 0 comments · Fixed by #378
Labels
bug Something isn't working

Comments

@erobot
Copy link
Contributor

erobot commented Sep 20, 2023

Search before asking

  • I searched in the issues and found nothing similar.

Version

OS: linux 4.14.105
Pulsar client: 3.1.0

Minimal reproduce step

  1. PartitionedProducer for a topic successfully created
  2. Update the topic to add new partitions
  3. PartitionedProducer creates producers for new partitions
  4. Some producers fail to create
  5. The failed producers cause PartitionedProducer to fail

What did you expect to see?

PartitionedProducer recreates failed producers, or producers continue to retry on failure.

What did you see instead?

The failed producers cause PartitionedProducer to fail.

Anything else?

Lazy producer seems to have a similar problem.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@merlimat merlimat added the bug Something isn't working label Sep 20, 2023
BewareMyPower pushed a commit that referenced this issue Jan 4, 2024
Fixes #319

### Motivation

Already created producer should not fail after new partition producers creation failure.

### Modifications

`ProducerImpl`: Add an option retryOnCreationError to control whether to retry on creation error
`PartitionedProducerImpl`: Use retryOnCreationError=true to create new partition producers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants