Expose BatchingMaxSize from ProducerOptions #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the producer maximum batch size was hard-coded to 128 KB.
Now, the produdcer maximum batch size is exposed via ProducerOptions
and defaults to 128 KB
Motivation
Different applications producing to Pulsar require different batching policies.
Previously, users had control over the maximum batching delay and the maximum number of messages in a batch, but could not control the maximum number of bytes in a batch. This change enables the latter.
Modifications
Expose a new
ProducerOption.BatchingMaxSize
(default: 128KB) that allows the user to configure the maximum batch size. This option has been plumbed throughpartition_producer
module to theinternal/batch_builder
module where it is used.Verifying this change
This change is already covered by existing tests, such as
producer_test.TestFlushInPartitionedProducer
andproducer_test.TestFlushInProducer
.Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesBatchingMaxSize
Documentation