Improve error log for frame size too big and maxMessageSize #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Feb 6, 2021
| @@ -348,7 +348,7 @@ func (p *partitionProducer) internalSend(request *sendRequest) { | |||
| p.log.WithError(errMessageTooLarge). | |||
| WithField("size", len(payload)). | |||
| WithField("properties", msg.Properties). | |||
| Error() | |||
| Errorf("MaxMessageSize %d", int(p.cnx.GetMaxMessageSize())) | |||
There was a problem hiding this comment.
Should we keep this in a structured form instead?
Suggested change
| Errorf("MaxMessageSize %d", int(p.cnx.GetMaxMessageSize())) | |
| WithField("max-message-size", int(p.cnx.GetMaxMessageSize())). | |
| Error() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to improve error log for
frame size too bigon the consumer. We have seen a number of frame size too big error and I would like to trace what the exact maxMessageSize is set to that is not default. Debug log was not able to be enabled on the production system.Modifications
Log improvement mostly
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation