-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: batch flush method #476
Conversation
Signed-off-by: jonyhy96 <hy352144278@gmail.com>
/cc @wolfstudy @freeznet |
There is a data race happens in the ci test. Should i fix it before merged or we could issue another pr for this? |
i think we should fix the ci test issue in another pr. |
Thanks @jonyhy96 work for this, please fix the ci error or send new pull request to fix this, thanks. And please make sure to create one issue to track this, thanks. |
The ci error is not caused by this pr. Maybe someone else can fix it. |
The |
Cool Thanks @jonyhy96 |
Fixes #475
Motivation
Fix wrong batch flush method bug.
Modifications
Check if batchBuilder is multi batches before flush.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation