Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support listener name for go client #502

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

wolfstudy
Copy link
Member

@wolfstudy wolfstudy commented Apr 6, 2021

Signed-off-by: xiaolongran rxl@apache.org

Motivation

In PIP-61, we introduce a new feature Advertised multiple addresses and in Java Client, we have implemented this function. correspondingly, we should also support this function in Go client.

Modifications

  • Add listenerName filed in lookupService struct
  • add test case for this feature

Verifying this change

  • Make sure that the change passes the CI checks.

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy wolfstudy added this to the 0.5.0 milestone Apr 6, 2021
@wolfstudy wolfstudy self-assigned this Apr 6, 2021
@wolfstudy
Copy link
Member Author

@wolfstudy
Copy link
Member Author

@freeznet PTAL thanks

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy wolfstudy merged commit f17deac into apache:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants