[#504] add http lookup service support #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go 1.15 enable Common Name matching revert auth changes add retry to httpclient, add tests
freeznet
force-pushed
the
freeznet/issue-504-add-http-lookup-service
branch
from
595ccf6
to
d4ad4e0
Compare
freeznet
changed the title
|
@merlimat @wolfstudy @jiazhai @codelipenghui Please help to review this PR, thanks. |
wolfstudy
approved these changes
Apr 15, 2021
codelipenghui
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
Master Issue: #504
Motivation
java-client has support http-based lookup: https://github.com/apache/pulsar/blob/12ef7c9b7ce698e6a8181700a2e8a2b030bcfa60/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java#L150
This pr adds http lookup service into
pulsar-client-go, to allow user use http/https protocol as service url.Modifications
HTTPLookupServiceHTTPClientVerifying this change
Documentation