continue cherry-pick UnAckedMessageRedeliveryTracker.java

apache · Nov 15, 2022 · 23fb813 · 23fb813
1 parent d237f50
commit 23fb813
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 33 deletions.
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageRedeliveryTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageRedeliveryTest.java
@@ -429,12 +429,14 @@ public void testMultiConsumerRedeliveryAddEpoch(boolean enableBatch) throws Exce
         final String subName = "my-sub";
         admin.topics().createPartitionedTopic(topic, 5);
         final int messageNumber = 50;
+        @Cleanup
         Consumer<String> consumer = pulsarClient.newConsumer(Schema.STRING)
                 .topic(topic)
                 .subscriptionName(subName)
                 .subscriptionType(SubscriptionType.Failover)
                 .subscribe();
 
+        @Cleanup
         Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
                 .topic(topic)
                 .enableBatching(enableBatch)

diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@ -460,10 +460,6 @@ protected Message<T> internalReceive() throws PulsarClientException {
         }
     }
 
-    boolean isValidConsumerEpoch(Message<T> message) {
-        return isValidConsumerEpoch((MessageImpl<T>) message);
-    }
-
     @Override
     protected CompletableFuture<Message<T>> internalReceiveAsync() {
         CompletableFutureCancellationHandler cancellationHandler = new CompletableFutureCancellationHandler();
@@ -1921,13 +1917,6 @@ public void redeliverUnacknowledgedMessages() {
         }
     }
 
-    public int clearIncomingMessagesAndGetMessageNumber() {
-        int messagesNumber = incomingMessages.size();
-        clearIncomingMessages();
-        unAckedMessageTracker.clear();
-        return messagesNumber;
-    }
-
     @Override
     public void redeliverUnacknowledgedMessages(Set<MessageId> messageIds) {
         if (messageIds.isEmpty()) {

diff --git a/...r-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java b/...r-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java
@@ -60,6 +60,7 @@ public UnAckedMessageRedeliveryTracker(PulsarClientImpl client, ConsumerBase<?>
             @Override
             public void run(Timeout t) throws Exception {
                 writeLock.lock();
+                Set<MessageId> messageIds = null;
                 try {
                     HashSet<UnackMessageIdWrapper> headPartition = redeliveryTimePartitions.removeFirst();
                     if (!headPartition.isEmpty()) {
@@ -71,9 +72,13 @@ public void run(Timeout t) throws Exception {
                     }
                     headPartition.clear();
                     redeliveryTimePartitions.addLast(headPartition);
-                    triggerRedelivery(consumerBase);
+                    messageIds = getRedeliveryMessages(consumerBase);
                 } finally {
                     writeLock.unlock();
+                    if (messageIds != null && !messageIds.isEmpty()) {
+                        consumerBase.onAckTimeoutSend(messageIds);
+                        consumerBase.redeliverUnacknowledgedMessages(messageIds);
+                    }
                     timeout = client.timer().newTimeout(this, tickDurationInMs, TimeUnit.MILLISECONDS);
                 }
             }
@@ -93,35 +98,29 @@ private void addAckTimeoutMessages(UnackMessageIdWrapper messageIdWrapper) {
         }
     }
 
-    private void triggerRedelivery(ConsumerBase<?> consumerBase) {
+    private Set<MessageId> getRedeliveryMessages(ConsumerBase<?> consumerBase) {
         if (ackTimeoutMessages.isEmpty()) {
-            return;
+            return null;
         }
         Set<MessageId> messageIds = TL_MESSAGE_IDS_SET.get();
         messageIds.clear();
 
-        try {
-            long now = System.currentTimeMillis();
-            ackTimeoutMessages.forEach((messageId, timestamp) -> {
-                if (timestamp <= now) {
-                    addChunkedMessageIdsAndRemoveFromSequenceMap(messageId, messageIds, consumerBase);
-                    messageIds.add(messageId);
-                }
-            });
-            if (!messageIds.isEmpty()) {
-                log.info("[{}] {} messages will be re-delivered", consumerBase, messageIds.size());
-                Iterator<MessageId> iterator = messageIds.iterator();
-                while (iterator.hasNext()) {
-                    MessageId messageId = iterator.next();
-                    ackTimeoutMessages.remove(messageId);
-                }
+        long now = System.currentTimeMillis();
+        ackTimeoutMessages.forEach((messageId, timestamp) -> {
+            if (timestamp <= now) {
+                addChunkedMessageIdsAndRemoveFromSequenceMap(messageId, messageIds, consumerBase);
+                messageIds.add(messageId);
             }
-        } finally {
-            if (messageIds.size() > 0) {
-                consumerBase.onAckTimeoutSend(messageIds);
-                consumerBase.redeliverUnacknowledgedMessages(messageIds);
+        });
+        if (!messageIds.isEmpty()) {
+            log.info("[{}] {} messages will be re-delivered", consumerBase, messageIds.size());
+            Iterator<MessageId> iterator = messageIds.iterator();
+            while (iterator.hasNext()) {
+                MessageId messageId = iterator.next();
+                ackTimeoutMessages.remove(messageId);
             }
         }
+        return messageIds;
     }
 
     @Override