log error when skip deleting

apache · Sep 7, 2022 · 7fe6bcd · 7fe6bcd
1 parent 86900ec
commit 7fe6bcd
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -3004,14 +3004,18 @@ private void offloadLoop(CompletableFuture<PositionImpl> promise, Queue<LedgerIn
                                            scheduledExecutor, name)
                             .whenComplete((ignore2, exception) -> {
                                     if (exception != null) {
-                                        log.error("[{}] Failed to offload data for the ledgerId {}",
-                                                name, ledgerId, exception);
-                                        if (exception instanceof MetaStoreException) {
+                                        Throwable e = FutureUtil.unwrapCompletionException(exception);
+                                        if (e instanceof MetaStoreException) {
                                             // When a MetaStore exception happens, we can not make sure the metadata
                                             // update is failed or not. Because we have a retry on the connection loss,
                                             // it is possible to get a BadVersion or other exception after retrying.
                                             // So we don't clean up the data if it has metadata operation exception.
+                                            log.error("[{}] Failed to update offloaded metadata for the ledgerId {}",
+                                                name, ledgerId, exception);
                                             return;
+                                        } else {
+                                            log.error("[{}] Failed to offload data for the ledgerId {}",
+                                                name, ledgerId, exception);
                                         }
                                         cleanupOffloaded(
                                             ledgerId, uuid,