Avoid triggering startReplProducer on newAddProducer as it may flips …

…replicator state wrongly
apache · Feb 22, 2017 · d9b1b4c · d9b1b4c
1 parent 4ac21b4
commit d9b1b4c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/...broker/src/main/java/com/yahoo/pulsar/broker/service/persistent/PersistentReplicator.java b/...broker/src/main/java/com/yahoo/pulsar/broker/service/persistent/PersistentReplicator.java
@@ -193,7 +193,7 @@ public synchronized void startProducer() {
                         // BackOff before retrying
                         brokerService.executor().schedule(this::startProducer, waitTimeMs, TimeUnit.MILLISECONDS);
                     } else {
-                        log.warn("[{}][{} -> {}] Failed to create remote producer. Replicator state: ", topicName,
+                        log.warn("[{}][{} -> {}] Failed to create remote producer. Replicator state: {}", topicName,
                                 localCluster, remoteCluster, STATE_UPDATER.get(this), ex);
                     }
                     return null;

diff --git a/pulsar-broker/src/main/java/com/yahoo/pulsar/broker/service/persistent/PersistentTopic.java b/pulsar-broker/src/main/java/com/yahoo/pulsar/broker/service/persistent/PersistentTopic.java
@@ -237,9 +237,6 @@ public void addProducer(Producer producer) throws BrokerServiceException {
             if (log.isDebugEnabled()) {
                 log.debug("[{}] [{}] Added producer -- count: {}", topic, producer.getProducerName(), USAGE_COUNT_UPDATER.get(this));
             }
-
-            // Start replication producers if not already
-            startReplProducers();
         } finally {
             lock.readLock().unlock();
         }