Derive direct memory used count from netty counter (#223) (#229)

* Derive direct memory used count from netty counter * Fix: avoid initial direct-memory assertion with 0
apache · Feb 21, 2017 · fa40001 · fa40001
1 parent 956430d
commit fa40001
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 3 deletions.
diff --git a/pulsar-broker/src/main/java/com/yahoo/pulsar/broker/stats/metrics/JvmMetrics.java b/pulsar-broker/src/main/java/com/yahoo/pulsar/broker/stats/metrics/JvmMetrics.java
@@ -16,6 +16,7 @@
 package com.yahoo.pulsar.broker.stats.metrics;
 
 import java.lang.management.ManagementFactory;
+import java.lang.reflect.Field;
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 
@@ -34,6 +35,8 @@
 import io.netty.buffer.PoolChunkListMetric;
 import io.netty.buffer.PoolChunkMetric;
 import io.netty.buffer.PooledByteBufAllocator;
+import io.netty.util.internal.PlatformDependent;
+import java.util.concurrent.atomic.AtomicLong;
 
 public class JvmMetrics extends AbstractMetrics {
 
@@ -46,6 +49,17 @@ public class JvmMetrics extends AbstractMetrics {
     private volatile long currentOldGcCount = 0;
     private volatile long accumulatedOldGcTime = 0;
     private volatile long currentOldGcTime = 0;
+
+    private static final Logger log = LoggerFactory.getLogger(JvmMetrics.class);
+    private static Field directMemoryUsage = null;
+    static {
+        try {
+            directMemoryUsage = PlatformDependent.class.getDeclaredField("DIRECT_MEMORY_COUNTER");
+            directMemoryUsage.setAccessible(true);
+        } catch (Exception e) {
+            log.warn("Failed to access netty DIRECT_MEMORY_COUNTER field {}", e.getMessage());
+        }
+    }
 
     public JvmMetrics(PulsarService pulsar) {
         super(pulsar);
@@ -64,8 +78,7 @@ public List<Metrics> generate() {
         m.put("jvm_max_memory", r.maxMemory());
         m.put("jvm_total_memory", r.totalMemory());
 
-        m.put("jvm_direct_memory_used",
-                sun.misc.SharedSecrets.getJavaNioAccess().getDirectBufferPool().getMemoryUsed());
+        m.put("jvm_direct_memory_used", getJvmDirectMemoryUsed());
         m.put("jvm_max_direct_memory", sun.misc.VM.maxDirectMemory());
         m.put("jvm_thread_cnt", getThreadCount());
 
@@ -95,6 +108,20 @@ public List<Metrics> generate() {
         return Lists.newArrayList(m);
     }
 
+    @SuppressWarnings("restriction")
+    public static long getJvmDirectMemoryUsed() {
+        if (directMemoryUsage != null) {
+            try {
+                return ((AtomicLong) directMemoryUsage.get(null)).get();
+            } catch (Exception e) {
+                if (log.isDebugEnabled()) {
+                    log.debug("Failed to get netty-direct-memory used count {}", e.getMessage());
+                }
+            }
+        }
+        return sun.misc.SharedSecrets.getJavaNioAccess().getDirectBufferPool().getMemoryUsed();
+    }
+
     private static ObjectName youngGenName = null;
     private static ObjectName oldGenName = null;
 
@@ -144,5 +171,4 @@ private long getThreadCount() {
         return parentThreadGroup.activeCount();
     }
 
-    private static final Logger log = LoggerFactory.getLogger(JvmMetrics.class);
 }
diff --git a/...r-broker/src/test/java/com/yahoo/pulsar/broker/stats/BookieClientsStatsGeneratorTest.java b/...r-broker/src/test/java/com/yahoo/pulsar/broker/stats/BookieClientsStatsGeneratorTest.java
@@ -26,6 +26,10 @@
 
 import com.yahoo.pulsar.broker.service.BrokerTestBase;
 import com.yahoo.pulsar.broker.stats.BookieClientStatsGenerator;
+import com.yahoo.pulsar.broker.stats.metrics.JvmMetrics;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.PooledByteBufAllocator;
 
 /**
  */
@@ -49,4 +53,33 @@ public void testBookieClientStatsGenerator() throws Exception {
         Map<String, Map<String, PendingBookieOpsStats>> stats = BookieClientStatsGenerator.generate(super.getPulsar());
         assertEquals((boolean) stats.isEmpty(), true);
     }
+
+    @Test
+    public void testJvmDirectMemoryUsedMetric() throws Exception {
+        PooledByteBufAllocator allocator = new PooledByteBufAllocator( //
+                true, // preferDirect
+                0, // nHeapArenas,
+                1, // nDirectArena
+                8192, // pageSize
+                11, // maxOrder
+                64, // tinyCacheSize
+                32, // smallCacheSize
+                8 // normalCacheSize
+        );
+        int allocateMemory = 17777216;
+        long directMemory1 = JvmMetrics.getJvmDirectMemoryUsed();
+        ByteBuf buf2 = allocator.directBuffer(allocateMemory, allocateMemory);
+        long directMemory2 = JvmMetrics.getJvmDirectMemoryUsed();
+        assertEquals(directMemory2, directMemory1 + allocateMemory);
+        ByteBuf buf3 = allocator.directBuffer(allocateMemory, allocateMemory);
+        long directMemory3 = JvmMetrics.getJvmDirectMemoryUsed();
+        assertEquals(directMemory3, directMemory2 + allocateMemory);
+        buf3.release();
+        directMemory3 = JvmMetrics.getJvmDirectMemoryUsed();
+        assertEquals(directMemory3, directMemory2);
+        buf2.release();
+        directMemory2 = JvmMetrics.getJvmDirectMemoryUsed();
+        assertEquals(directMemory2, directMemory1);
+
+    }
 }