pulsar-client-cpp fails to build on mac

[jai1]

Expected behavior

On mac machine

./pulsar-client-cpp 
cmake .

should be successful

Actual behavior

cmake fail instead since

• ./pulsar-client-cpp/lib/CMakeLists.txt assumes that grep and sed are kept in /bin and grep can support -Po option
• ./pulsar-client-cpp/CMakeLists.txt doesn't contain GTEST_INCLUDE_PATH

Steps to reproduce

Mentioned in Expected behavior section

System configuration

Pulsar version: x.y

Work around

replace the file ./pulsar-client-cpp/lib/CMakeLists.txt contents with

file(GLOB PULSAR_SOURCES *.cc lz4/*.c checksum/*.cc)

set (CMAKE_CXX_FLAGS " ${CMAKE_CXX_FLAGS} -msse4.2 -mpclmul")

add_library(pulsarStatic STATIC ${PULSAR_SOURCES})
add_library(pulsarShared SHARED ${PULSAR_SOURCES})

set_target_properties(pulsarStatic PROPERTIES OUTPUT_NAME pulsar)
set_target_properties(pulsarShared PROPERTIES OUTPUT_NAME pulsar)

target_link_libraries(pulsarStatic ${COMMON_LIBS})
target_link_libraries(pulsarShared ${COMMON_LIBS})

add_subdirectory(auth)

replace the file ./pulsar-client-cpp/CMakeLists.txt contents with

cmake_minimum_required(VERSION 2.8)
project (pulsar-cpp)

set(Boost_NO_BOOST_CMAKE ON)

set (CMAKE_CXX_FLAGS "-Wno-deprecated-declarations ${CMAKE_CXX_FLAGS}")

find_package(Boost REQUIRED COMPONENTS program_options filesystem regex thread system)
find_package(OpenSSL REQUIRED)
find_package(ZLIB REQUIRED)
find_package(ProtoBuf QUIET)
if(NOT ProtoBuf_FOUND)
  find_library(PROTOBUF_LIBRARIES protobuf)
endif()
find_library(LOG4CXX_LIBRARY_PATH log4cxx)
find_library(CURL_LIBRARY_PATH curl)

find_path(LOG4CXX_INCLUDE_PATH log4cxx/logger.h)
find_path(GTEST_INCLUDE_PATH gtest/gtest.h)


include_directories(
  ${CMAKE_SOURCE_DIR}
  ${CMAKE_SOURCE_DIR}/include
  ${Boost_INCLUDE_DIR}
  ${OPENSSL_INCLUDE_DIR}
  ${ZLIB_INCLUDE_DIR}
  ${PROTOBUF_INCLUDE_DIR}
  ${LOG4CXX_INCLUDE_PATH}
  ${GTEST_INCLUDE_PATH}
)

set(COMMON_LIBS
  ${COMMON_LIBS}
  ${Boost_LIBRARIES}
  ${OPENSSL_LIBRARIES}
  ${ZLIB_LIBRARIES}
  ${PROTOBUF_LIBRARIES}
  ${LOG4CXX_LIBRARY_PATH}
  ${CURL_LIBRARY_PATH}
)

link_directories(${CMAKE_BINARY_DIR}/lib)

set(CLIENT_LIBS
  ${COMMON_LIBS}
  pulsar
)

add_subdirectory(lib)
add_subdirectory(perf)
add_subdirectory(examples)
add_subdirectory(tests)

[merlimat]

@jai1 Can you also add instructions on how to install dependencies on Mac in the c++ readme page?

[saandrews]

Along with that, Jai1 is trying to find ways to install platform dependancies through cmake itself.

…

On Thu, Feb 9, 2017 at 10:38 AM, Matteo Merli ***@***.***> wrote: @jai1 <https://github.com/jai1> Can you also add instructions on how to install dependencies on Mac in the c++ readme page? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#198 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATk4LKmSLy_200y2NED40hQvYG5GpNVtks5ra10zgaJpZM4L7iYs> .