Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache protobuf and gtest compilation in Travis build #263

Closed
merlimat opened this issue Mar 1, 2017 · 2 comments
Closed

Cache protobuf and gtest compilation in Travis build #263

merlimat opened this issue Mar 1, 2017 · 2 comments
Assignees
@jai1
Labels
area/test
Milestone
1.17

Comments

@merlimat
Copy link
Contributor

merlimat commented Mar 1, 2017

Expected behavior

We shouldn't fetch protobuf and gtest from the network and recompile it every time we do a build.

Binary should be cached and the build script should check for their presence in cache.

To cache the files, take a look at the .travis.yml file:

cache:
  directories:
  - $HOME/.m2
  - $HOME/pulsar-dep

Just need to put them in these directories and they will be still around on the next build.
@merlimat merlimat added this to the 1.17 milestone Mar 1, 2017
@merlimat
Copy link
Contributor Author

@jai1 was this already fixed?

@jai1 jai1 added the c++ label Mar 24, 2017
@jai1
Copy link
Contributor

jai1 commented Mar 24, 2017

Yes #278

@jai1 jai1 closed this as completed Mar 24, 2017
sijie added a commit to sijie/pulsar that referenced this issue Mar 4, 2018
@sijie
Provide a distribution package for pulsar functions (apache#263)
e5ed2ed 
- the package will be generated under `dist/target/`
hrsakai pushed a commit to hrsakai/pulsar that referenced this issue Dec 10, 2020
@izackwu
[Issue 240] Add check for max message size (apache#263)
bf248fd 
* Add check for max message size

1. When creating a connection, try to get maxMessageSize from handshake
response command. If it's not set, then use the default maxMessageSize
value defined in the client side.
2. When sending a message, check whether the size of payload exceeds
maxMessageSize. If so, return error immediately without adding this
meesage into sending queue.
3. To implement these, I made some tiny modifications in Connection
interface and added a field in its implementation struct.

* Add testing for max message size

* Fix error log
hangc0276 pushed a commit to hangc0276/pulsar that referenced this issue May 26, 2021
@dockerzhang
kop using pulsar consumer metrics (apache#263)
cda07d7 
fix for apache#248
@xiaotongwang1 xiaotongwang1 mentioned this issue Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jai1 jai1

Labels
area/test
Projects
None yet
Milestone
1.17
Development

No branches or pull requests
2 participants
@merlimat @jai1