Fix: complete MessageReplay immediately if there is no entry to replay which will not block further reads as current Replay is finished #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich will not block reads from other consumer
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While doing messageReplay: if all the replay-entries are already acked then Dispatcher was not replaying any entry and also was not receiving a
ReadEntriesCallbackwhich keepsmessagesToReplayin pending state and further reads couldn't read next entries.Modifications
If all the replay-entries are already acked
messagesToReplaybucketmessagesToReplayflag completeResult
Dispatcher will immediately mark
messagesToReplayflag complete incase of all invalid-entries for replay and continue reading more messages and consumer will not be blocked while receiving messages.