Avoid setting ReplicatedFrom attribute with empty value while init batchMessageMetadata #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
rdhabalia
changed the title
merlimat
reviewed
Nov 11, 2016
| @@ -611,7 +611,6 @@ public static long initBatchMessageMetadata(PulsarApi.MessageMetadata.Builder me | |||
| messageMetadata.setPublishTime(builder.getPublishTime()); | |||
| messageMetadata.setProducerName(builder.getProducerName()); | |||
| messageMetadata.setSequenceId(builder.getSequenceId()); | |||
| messageMetadata.setReplicatedFrom(builder.getReplicatedFrom()); | |||
There was a problem hiding this comment.
Good catch! Would it be worth to use "if (hasReplicatedFrom()) setTeplicatedFrom()" ?
There was a problem hiding this comment.
Can you also add a test in the replication unit test for batch messages? It should have caught this
There was a problem hiding this comment.
Addressed the changes.
merlimat
reviewed
Nov 11, 2016
| producerConfiguration.setBatchingMaxMessages(5); | ||
| } | ||
| producer = client.createProducer(topicName); |
There was a problem hiding this comment.
Ouch, we weren't passing the producer config!
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As Batch-message was setting
ReplicatedFromwith empty value, while replicating this batch message broker skips replication as broker considers this message as already replicated.Modifications
Do not set
ReplicatedFromfield of Metadata with empty value.Result
Broker will be able to replicate batch messages.