-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 11185][pulsar-brokers test] Fix failing auth test. #11186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Jul 2, 2021
merlimat
approved these changes
Jul 2, 2021
eolivelli
approved these changes
Jul 2, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 3, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 63ebc0a)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 63ebc0a)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 12, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 63ebc0a)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 20, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com> (cherry picked from commit 63ebc0a)
ivankelly
pushed a commit
to ivankelly/pulsar
that referenced
this pull request
Aug 10, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com>
pkumar-singh
pushed a commit
to pkumar-singh/pulsar
that referenced
this pull request
Aug 10, 2021
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com>
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
The hard coded token has expired causing the test to fail. Instead of hardcoding the token, we can generate the token dynamically and avoid this problem in future Co-authored-by: Surinder Singh <surinders@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.7
Archived: 2.7 is end of life
cherry-picked/branch-2.8
Archived: 2.8 is end of life
release/2.7.3
release/2.8.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11185
Motivation
TokenAuthenticatedProducerConsumerTest is currently broken due to expiry of hard coded token.
Modifications
Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future
Verifying this change
Does this pull request potentially affect one of the following parts:
No
Documentation