Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 11185][pulsar-brokers test] Fix failing auth test. #11186

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

sursingh
Copy link
Contributor

@sursingh sursingh commented Jul 1, 2021

Fixes #11185

Motivation

TokenAuthenticatedProducerConsumerTest is currently broken due to expiry of hard coded token.

Modifications

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Verifying this change

  • Make sure that the change passes the CI checks.
  • The change is fixing a broken test.

Does this pull request potentially affect one of the following parts:

No

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why? Not a feature. Fixing an existing testcase
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future
@sursingh
Copy link
Contributor Author

sursingh commented Jul 2, 2021

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui added this to the 2.9.0 milestone Jul 2, 2021
@eolivelli eolivelli merged commit 63ebc0a into apache:master Jul 2, 2021
codelipenghui pushed a commit that referenced this pull request Jul 3, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
(cherry picked from commit 63ebc0a)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jul 4, 2021
codelipenghui pushed a commit that referenced this pull request Jul 7, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
(cherry picked from commit 63ebc0a)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 7, 2021
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Jul 12, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
(cherry picked from commit 63ebc0a)
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Jul 20, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
(cherry picked from commit 63ebc0a)
ivankelly pushed a commit to ivankelly/pulsar that referenced this pull request Aug 10, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
pkumar-singh pushed a commit to pkumar-singh/pulsar that referenced this pull request Aug 10, 2021
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
The hard coded token has expired causing the test to fail.

Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future

Co-authored-by: Surinder Singh <surinders@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.7.3 release/2.8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[broker test] auth test broken due to token expiry
4 participants