Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed using CommandSubscribe.getConsumerName() without checking #11199

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jul 2, 2021

Motivation

Fixes #11156

On ServerCnx we're using the consumer name which is an optional field in the protobuf definition, without checking if the field was set. While Java/C++/Go are always setting that field, other client might not passing it.

@merlimat merlimat added type/bug The PR fixed a bug or issue reported a bug release/2.8.1 labels Jul 2, 2021
@merlimat merlimat added this to the 2.9.0 milestone Jul 2, 2021
@merlimat merlimat self-assigned this Jul 2, 2021
@merlimat merlimat merged commit 707cb1a into apache:master Jul 2, 2021
@merlimat merlimat deleted the consumer-name branch July 2, 2021 18:21
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Jul 5, 2021
eolivelli pushed a commit that referenced this pull request Jul 5, 2021
@eolivelli eolivelli added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 5, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer Name is required in 2.8.0
3 participants