Fix LinuxBrokerHostUsageImpl scheduled timer #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
merlimat
approved these changes
Nov 16, 2016
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Fixes apache#111 Subscriber.Subscription() should return the subscription name instead of returns ""
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…che#114) Fix apache#113 In current request handler. we passed in the request and after some handles return a responseFuture. If several request comes in at same time, the handling time difference will cause the return future order different with the order that command comes in. And this will cause request handling order different. This error is seen in the KafkaMessageOrderTest: - client send 10 messges, while first 9 messages batched together, and the last one not batched; - the above 2 request comes into handleProduceRequest, but the second request returned earlier than the first. The fix is: - add request response future in order at the time that request comes in, and call related handlers later. - add produce request in order, and handle one by one in each channel. * add request response future at the time request comes * make produce request in order * change cursor delete to async in KafkaTopicConsumerManager * add some logs of offset
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this in #88