[#114] Process ZK event from background thread to avoid deadlock on ZK sync operations #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k on ZK sync operations
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…pache#115) when channel is closing, there is some race that cased tcm.add(offset) add cursor back, but these cursors may able to be deleted. - add lock and close state in KafkaTopicConsumerManager and KafkaTopicManager, avoid operation when channel closing. - change KafkaTopicConsumerManager to keep Pair<ManagedCursor, Long> instead of Future<Pair>. - handling logic in MessageFetchContext to make sure cursor add back to tcm or deleted when error. - add a createdCursor to delete all the cursors when close. Co-authored-by: Sijie Guo <guosijie@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As described in #114 there is a deadlock after a bundle split due to a mix of async and sync ZK operations that keep the ZK MainEvent thread deadlocked.
Modifications
Process the ZK async response from a background thread to release MainEvent thread immediately.
Result
The resulting code should not deadlock.