-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donot create transaction components for function work topic #11543
Closed
liangyepianzhou
wants to merge
10
commits into
apache:master
from
liangyepianzhou:Donot_create_transaction_components_for_FunctionWork_topic
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc925d9
Filter out FunctionWorkServiceTopic when creating transactionPendingA…
liangyepianzhou b479659
Test draft
liangyepianzhou 7d13135
rollback
liangyepianzhou aba6b5b
Add test to verify that the specified topic is filtered
liangyepianzhou 62d5bef
close transaction in standalone.
liangyepianzhou 71271d1
modify the way of handling exception and geting wrokerConfig.
liangyepianzhou 2cd7c32
Fix WhitespaceAround
liangyepianzhou 3e9da9e
Fix fnWorkerConfigFile get
liangyepianzhou 373b3b1
optimize CheckTopicIsSpecial and test
liangyepianzhou f2da179
optimize CheckTopicIsSpecial and test
liangyepianzhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/CheckTopicIsSpecial.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.broker.service.persistent; | ||
|
|
||
| import org.apache.logging.log4j.core.util.Assert; | ||
| import org.apache.pulsar.functions.worker.WorkerConfig; | ||
|
|
||
| public class CheckTopicIsSpecial { | ||
| public static boolean checkTopicIsFunctionWorkerService(PersistentTopic topic) { | ||
| if (!Assert.isNonEmpty(topic)){ | ||
| throw new IllegalArgumentException("topic can`t be null"); | ||
| } | ||
| WorkerConfig workerConfig = topic.getBrokerService().getPulsar().getWorkerConfig().get(); | ||
| String topicName = topic.getName(); | ||
| return workerConfig.getClusterCoordinationTopic().equals(topicName) | ||
| || workerConfig.getFunctionAssignmentTopic().equals(topicName) | ||
| || workerConfig.getFunctionMetadataTopic().equals(topicName); | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can only work for the broker run with the function worker? If the function working running independently, here will get an incorrect worker config.
I think we already have a PR to support transaction buffer and pending ack lazy creation, if new transactions happens on a topic, the transaction buffer and the pending ack will not be created?