-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 11581][broker] feat:pass the executor to RateLimiter in ResourceGroupPublishLimiter #11582
Conversation
pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java
Outdated
Show resolved
Hide resolved
Thanks for providing doc-related info! |
.permits(publishMaxMessageRate) | ||
.rateTime(1L) | ||
.timeUnit(TimeUnit.SECONDS) | ||
.isDispatchOrPrecisePublishRateLimiter(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default value is false, so there's no need to set isDispatchOrPrecisePublishRateLimiter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@leizhiyuan There are quite a few flaky tests. I assume you faced #11096 . When you suspect a flaky test, please search in the GitHub issue with the short name of the test class for possible reported flaky tests. It is possible to retry a failed CI build by adding a comment "/pulsarbot rerun-failure-checks" to the PR.
Reporting a new Flaky issue can be done by choosing "Flaky test" on the new |
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupPublishLimiter.java
@leizhiyuan Thank you for taking care of this. Passing the Executor was one of the tasks in my TODO list (which I why I left the comment in the code). Glad you were able to get to it before I could. Just to clarify though, I don't think this addresses any flaky tests. The flaky tests reported in: are because of a code issue, where the zookeeper watch events were getting fixed. The race condition was reported in #11157 and fixed in #11198 |
LGTM |
…ceGroupPublishLimiter (apache#11582) ### background Fixes apache#11581 ### Motivation we need to pass the executor to RateLimiter in ResourceGroupPublishLimiter ### Modifications pass the executor to RateLimiter in ResourceGroupPublishLimiter
background
Fixes #11581
Motivation
we need to pass the executor to RateLimiter in ResourceGroupPublishLimiter
Modifications
pass the executor to RateLimiter in ResourceGroupPublishLimiter
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
no, there is no change for users.