avoid create new subscription name for reader if it's already configed #11586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a reader, pulsar will create a new subscription name first without checking whether it's existed or not.
This pull request aims to avoid create a new subscription name for reader if it's already set before.
Modifications
Check subscription from the
ReaderConfigurationData
first and if already exist, we do not need to create a subscription name.Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
no document need be added or updated since this change has nothing to do with API and configuration