Fix all web threads will get stuck when deleting the namespace #11596
Conversation
codelipenghui
added
type/bug
| @@ -227,7 +227,8 @@ protected void internalDeleteNamespace(AsyncResponse asyncResponse, boolean auth | |||
| boolean isEmpty; | |||
| List<String> topics; | |||
| try { | |||
| topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName).join(); | |||
| topics = pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName) | |||
There was a problem hiding this comment.
nice catch!
There are many places which call getListOfPersistentTopics also use join to get the CompletableFuture result, would you please fix them? thanks.
There was a problem hiding this comment.
Ok, I'll start a new PR and fix all the places where join is used
|
2.7.x will also have this problem, do we need to move it to 2.7.x? |
|
I am not sure that this patch applies to 2.7.x. if no user reported this problem it is better to not cherry pick patches to a "stable" branch. In my opinion we should cherry pick only the strictly needed patches, as far as a branch becomes "old" it is better to port only security related fixes or fixes about consistency or data loss. The more commits we cherry pick the more likely it is that we make the branch less stable |
(cherry picked from commit c4a2572)
hangc0276
added
cherry-picked/branch-2.8
Motivation
Since join() does not time out, all threads are blocked here.
