Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pulsar-standalone image #11657

Merged

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Aug 13, 2021

Motivation

Currently, the pulsar-dashboard has been removed in #11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image.

in #11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master.

I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes.

Modifications

  • remove pulsar-standalone image

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

For contributor

For this PR, do we need to update docs?

  • If yes, please update docs or create a follow-up issue if you need help.

  • If no, please explain why.

For committer

For this PR, do we need to update docs?

  • If yes,

    • if you update docs in this PR, label this PR with the doc label.

    • if you plan to update docs later, label this PR with the doc-required label.

    • if you need help on updating docs, create a follow-up issue with the doc-required label.

  • If no, label this PR with the no-need-doc label and explain why.

@freeznet freeznet self-assigned this Aug 13, 2021
@freeznet freeznet added this to the 2.9.0 milestone Aug 13, 2021
@freeznet freeznet added the doc-not-needed Your PR changes do not impact docs label Aug 13, 2021
@sijie sijie merged commit 05827ae into apache:master Aug 13, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

Currently, the pulsar-dashboard has been removed in apache#11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image.

in apache#11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master. 

I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes.

### Modifications

- remove pulsar-standalone image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants