Initialize lookup-request variables locally before request-instance recycle #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
merlimat
reviewed
Nov 17, 2016
| @@ -151,39 +151,42 @@ protected void handleLookup(CommandLookupTopic lookup) { | |||
| if (log.isDebugEnabled()) { | |||
| log.debug("Received Lookup from {}", remoteAddress); | |||
| } | |||
| lookupDestinationAsync(getBrokerService().pulsar(), DestinationName.get(lookup.getTopic()), | |||
| final long requestId = lookup.getRequestId(); | |||
| @@ -238,17 +241,18 @@ protected void handleSubscribe(final CommandSubscribe subscribe) { | |||
| } else { | |||
| authorizationFuture = CompletableFuture.completedFuture(true); | |||
| } | |||
| final String topicName = subscribe.getTopic(); | |||
| @@ -71,7 +71,7 @@ | |||
|
|
|||
| private final AtomicLong producerIdGenerator = new AtomicLong(); | |||
| private final AtomicLong consumerIdGenerator = new AtomicLong(); | |||
| protected static final AtomicLong requestIdGenerator = new AtomicLong(); | |||
| protected final AtomicLong requestIdGenerator = new AtomicLong(); | |||
| @@ -364,6 +364,10 @@ long newConsumerId() { | |||
| long newRequestId() { | |||
| return requestIdGenerator.getAndIncrement(); | |||
| } | |||
|
|
|||
| ConnectionPool getCnxPool() { | |||
| return cnxPool; | |||
rdhabalia
force-pushed
the
lk_rcy
branch
3 times, most recently
from
3a20361
to
c7be724
Compare
|
Addressed the changes. |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* fixing response codes and cli * cleaning up * fixing unit tests
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Feb 9, 2021
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…est !56) Fix the system topic schema not compatible bug. (apache#117)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As lookup (PartitionMetadata/Lookup-topic) requests being processed async: Lookup-request instance gets recycled immediately after main-io thread completes its process and triggers async-processing of request in a different thread. So, we need to copy request-variables locally for processing-thread before instance gets recycled.
Modifications
Initialize lookup-request variable locally before Lookup-request instance gets recycled.
Result
It returns lookup-response with correct response-value.