-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DbLedgerStorage configuration keys with default values in bookkeeper.conf #123
Conversation
CLA is valid! |
@merlimat do you have any recommendations for rocksdb tuning? I believe if we set Is there a good ratio between |
@sschepens In DbLedgerStorage, RocksDB is used to just store the indexes, not the actual entries payloads. All writes to RocksDB are done in a background flush thread, so the stall are not a concern here. To recap:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Added publish interface to the api * Address comments
apache#124) * [Issue apache#123] Ensure message is sent if no room in current batch. * Add issue to test comment. * Increase test wait timeout. * Add timeout log for test. * Add log when a single message fails to be added to batch.
Updates Message.cc to include support for delayed delivery from the C++ client. (pulsar_message_set_deliver_after & pulsar_message_set_deliver_at) Co-authored-by: savearray2 <savearray2>
* reuse ordering key to avoid String and bytes converting for message key * update to pulsar 2.5.0-ad0224407, this verison is closer to 2.5.1, and include some fix like ratelimit in pulsar
Motivation
Added missing configuration keys for BookKeeper DbLedgerStorage